Code Review – Guidelines

I’ve taken on a new role for a software project based on Embarcadero Delphi code, that of Code Reviewer.

I’m a C++ programmer and have little experience with actually writing or debugging Delphi code.

So does that mean that I am the wrong man for the job?

Here are two things I won’t be doing:

I won’t be testing the code by running it (other people in the development team will be doing this alongside the original testing done by each other programmer as he/she develops the code).

I won’t be looking for syntax errors. The code should compile and run before it is passed to the code reviewer.

So what will I be doing?

I will be looking at the overall method used to perform the functions. Is it a sensible algorithm? Are looping structures sensibly implemented?
I will be looking at the choice of names used for variables, procedures and functions (there are plenty of blog postings about this here!).

I will be looking at comments, particularly any lengthy text that summarises the tasks achieved by the code to try to ensure that they are clear and simply written yet are accurate and complete and not open to misinterpretation. I will also check that they actually exist at the top of each source code file.

Whilst doing so I will be careful to be positive and respectful to my fellow team members. In particular for many, English (the language used for the code and comments) may not be the native language of some of the team members so any grammar / spelling or improvements to accuracy or coherency of explanation will be done in a sensitive manner.

That’s my aim.

If you consider these items you realise that in depth experience with Delphi is not a prerequisite to achieving the aims. In fact it may be argued that a lack of in depth expertise may even be useful!

#Delphi25th – Embarcadero Delphi is 25 Years Old !

Delphi25

2020 marks the 25th Anniversary since the launch of Delphi and Visual Component Library (VCL) back in 1995.

 Everytime a C++ Programmer writes using the Embarcadero VCL they are also using Delphi “under the hood”. The power and flexibility that this combination yields is one of the things that makes the Embarcadero RAD studio the “best in class” product.

You can see my happy birthday message by clicking here.

 Happy birthday video from Roger

Embarcadero RAD Studio Rio 10.3.3 is here !

Embarcadero have just announced the availability of RAD Studio Rio 10.3.3.

This introduces Android 64 bit support for Delphi users and Mac iOS 13 App Store for both Delphi and C++, as well as a host of other significant fixes and improvements.

So what are you waiting for? Go get it!

Here are some useful links.

What’s new in Rio 10.3.3

10.3.3 Summary (including a video)

Embarcadero CodeRage 2019 is Here !

CodeRage 2019 Full

Embarcadero’s annual on line series of webinars is back again !

This time they’ve changed the format to make it a large number of smaller videos, allowing you to dip in and out much more easily.

There is an overall theme for each week.

 For more about CodeRage 2019 (including the list of each of the active weeks and how to register) go to Jim’s CodeRage2019 Blog

 

Android 64 bit compilation requirements – a possible way around the limitation

As in my posting of Posted on 29th May 2019 it seems that Embarcadero have dropped the ability to compile for 64bit Android from the road map completely.

 This seems disastrous for all C++ Android / Firemonkey developers.

 One of the big names in Embarcadero C++ programming is Remy Lebeau.

He has offered a work around for C++ Android / Firemonkey developers at the following link.

How to get Android 32 bit apps onto google play store

It’s worth pointing out that this is only a short term solution and every C++ Android / Firemonkey developer should still be doing their best to pressurise Embarcadero to reconsider their decision.

 

Embarcadero Latest Road Map (May 2019)

 The latest road map for Embarcadero RAD Studio, C++ Builder and Delphi is now available at the link below.

 Multi-device Delphi users will be impressed with soon-to-be-with-us options and multi-device C++ users may be less impressed with the failure of the C++ side of multi-device development failing to keep up…..

 It’s an interesting read, here’s the link.

Embarcadero Road Map (May 2019)